Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2116 PS4, Line 2116: in Kudu that is integrated with Hive : Metastore. nit: maybe rephrase, "...if the Kudu service is integrated with the Hive Metastore." Same elsewhere. http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115 PS4, Line 2115: This : operation is not supported in Kudu that is integrated with Hive : Metastore. > I don't think that this is correct. The design doc says that this applies t We have been using the term "orphaned table" to refer to a Kudu table that does not have a corresponding HMS entry that points to it. This would open the door for inconsistencies between the HMS and Sentry namespace, illustrated by this example: Alice has read permission on table default.TableA in the HMS, and an orphaned table in Kudu happens to be named the same. Now Alice has read permission to the Kudu table. The checking happens on the HMS side, via the Kudu plugin, per this patch: https://github.com/apache/kudu/commit/3f480941156068342dc2c66e38553712623d959e#diff-2b0d216b09b8edb51b0e735c485400e2 http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml File docs/topics/impala_kudu.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116 PS4, Line 1116: <note>This section only applies the Kudu services that are not > This patch mostly just points out things that no longer apply. Is there an Upstream Kudu has just updated its docs to include both of these: https://kudu.apache.org/docs/hive_metastore.html http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml File docs/topics/impala_tables.xml: http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@289 PS4, Line 289: Some : information about the table is stored in the metastore database for use : by Impala. Other table metadata is managed internally by Kudu. Actually all data that Impala needs is stored in the HMS (including things that Kudu doesn't necessarily know about right now, like stats). Some of that may also be stored in Kudu (schemas, etc.). http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@293 PS4, Line 293: <p> : In the Kudu services enabled to use Hive Metastore (HMS), all metadata : is managed by HMS. : </p> This isn't quite right. Mostly it's managed by Kudu. Some Impala-specific things are managed by Impala still (stats, for example). We may want to consider leaving this sentence off. http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336 PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix > Maybe move this up to be directly after the paragraph that talks about '::' +1 Might consider merging this with that sentence, something like: "When Kudu is not integrated with the HMS, when you create a Kudu table through Impala, the table is assigned an internal Kudu table name of the form ..." -- To view, visit http://gerrit.cloudera.org:8080/13776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e Gerrit-Change-Number: 13776 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Wed, 10 Jul 2019 00:51:41 +0000 Gerrit-HasComments: Yes
