Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 )
Change subject: IMPALA-8593: Support table capabilities handling with Hive 3 ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/13558/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13558/10//COMMIT_MSG@26 PS10, Line 26: Can you add a TODO about ugpraded tables? My impression is that creating a normal table then altering it to insert only ACID will leave the capabilities in the old state. http://gerrit.cloudera.org:8080/#/c/13558/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/13558/7/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@92 PS7, Line 92: eUtils.valida > Done This change doesn't seem logical to me - the major version that getMajorVersion() returns should be the Hive version, while IMPALA_MAJOR_VERSION should be the Impala version. It is just a coincidence that both are 3, Impala's version could be raised to 4 any time, and if getMajorVersion() would also return 4, it would break some existing code. The best would be to initialize this after BackendConfig - as far as I understand this happens extremely early and frontend code generally relies on it. -- To view, visit http://gerrit.cloudera.org:8080/13558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia08d01168660830b6e0d08b55a95eac129889cec Gerrit-Change-Number: 13558 Gerrit-PatchSet: 10 Gerrit-Owner: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Sudhanshu Arora <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Jul 2019 17:17:58 +0000 Gerrit-HasComments: Yes
