Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13558 )
Change subject: IMPALA-8593: Support table capabilities handling with Hive 3 ...................................................................... Patch Set 11: (2 comments) Submit patch 11 with: 1. Use Impala build number by calling BackendConfig. 2. Add ToDo for alter table (nonacid to acid) table properties changes. 3. Rebase and re-run Hive 2 and Hive 3 core Hive 2 all passed: https://master-02.jenkins.cloudera.com/job/impala-private-parameterized/5404/testReport/ Hive 3 7 failures, no regressions: https://master-02.jenkins.cloudera.com/job/impala-private-parameterized/5402/testReport/ http://gerrit.cloudera.org:8080/#/c/13558/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13558/10//COMMIT_MSG@26 PS10, Line 26: When upgrade tables from non-acid to acid, the default > Can you add a TODO about ugpraded tables? My impression is that creating a Done http://gerrit.cloudera.org:8080/#/c/13558/7/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java: http://gerrit.cloudera.org:8080/#/c/13558/7/fe/src/main/java/org/apache/impala/catalog/MetaStoreClientPool.java@47 PS7, Line 47: // Key for config option read from hive-site.xml : private static final String HIVE_METASTORE_CNXN_DELAY_MS_CONF = : "impala.catalog.metastore.cnxn.creation.delay.ms"; : private static final int DEFAULT_HIVE_METASTORE_CNXN_DELAY_MS_CONF = 0; : / > Here to make sure the client capabilities are set before the pool start to new patch moves the code out of the static block. -- To view, visit http://gerrit.cloudera.org:8080/13558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia08d01168660830b6e0d08b55a95eac129889cec Gerrit-Change-Number: 13558 Gerrit-PatchSet: 11 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Sudhanshu Arora <sudhan...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sat, 13 Jul 2019 10:55:55 +0000 Gerrit-HasComments: Yes
