Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13769 )
Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.h@358 PS2, Line 358: static Status MemLimitExceeded(MemTracker* mtracker, RuntimeState* state, Can you add a brief comment, just to explain that this exists so that mtracker can be nullptr http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc@421 PS2, Line 421: mtracker mtracker != nullptr to be more explicit http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc@437 PS2, Line 437: mtracker mtracker != nullptr to be more explicit -- To view, visit http://gerrit.cloudera.org:8080/13769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 Gerrit-Change-Number: 13769 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 15:28:22 +0000 Gerrit-HasComments: Yes
