Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/13769 )
Change subject: IMPALA-5031: method calls on NULL are not UBSAN-clean ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.h File be/src/runtime/mem-tracker.h: http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.h@358 PS2, Line 358: /// Makes MemLimitExceeded callable for nullptr MemTrackers. > Can you add a brief comment, just to explain that this exists so that mtrac Done http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc File be/src/runtime/mem-tracker.cc: http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc@421 PS2, Line 421: mtracker > mtracker != nullptr to be more explicit Done http://gerrit.cloudera.org:8080/#/c/13769/2/be/src/runtime/mem-tracker.cc@437 PS2, Line 437: mtracker > mtracker != nullptr to be more explicit Done -- To view, visit http://gerrit.cloudera.org:8080/13769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id62d1c504a273451dc1be6831a473f6c7115b403 Gerrit-Change-Number: 13769 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 20 Jul 2019 01:59:11 +0000 Gerrit-HasComments: Yes
