Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13776 )

Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................


Patch Set 7:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116:  in Kudu that is integrated with Hive Metastore
drop


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2115
PS8, Line 2115: this operation
              :         is
these operations

As I remember, both 'managed/internal --> external' and 'external --> 
managed/internal' are prohibited.  As I read it the added note in PS8 revision, 
it's not quite clear whether it's about both SQL statements above or just the 
latter.


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116:
nit: extra space


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4540
PS8, Line 4540:
nit: extra space


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
              :         with the Hive Metastore, Kudu stores all its metadata 
in HMS.
I thought it was vice-versa, no?

Also, it sounds like all Kudu's metadata on tables is stored in HMS, but that's 
not correct.  IIUC, as of now Kudu stores in HMS the metadata to make its 
tables discoverable via the HMS catalog and accessible by HMS-compatible SQL 
engines like Impala.  Not sure whether that's the best wording, though.


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4546
PS8, Line 4546:
nit: an extra space


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4577
PS8, Line 4577:
nit: an extra space



--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jul 2019 18:13:56 +0000
Gerrit-HasComments: Yes

Reply via email to