Alex Rodoni has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13776 )

Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................


Patch Set 8:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116:
> nit: extra space
Done


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116:  in Kudu that is integrated with Hive Metastore
> drop
Done


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2115
PS8, Line 2115: this operation
              :         is
> these operations
Done


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4540
PS8, Line 4540:
> nit: extra space
Done


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
              :         with the Hive Metastore, Kudu stores all its metadata 
in HMS.
> Ah good catch. This should probably be something like, "If the Kudu service
Done


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4546
PS8, Line 4546:
> nit: an extra space
Done


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
              :         with the Hive Metastore, Kudu stores all its metadata 
in HMS.
> I thought it was vice-versa, no?
Fixed as Andrew recommended.


http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4577
PS8, Line 4577:
> nit: an extra space
Done.
Actually, the editor adds spaces like this.



--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jul 2019 22:44:06 +0000
Gerrit-HasComments: Yes

Reply via email to