Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function ...................................................................... Patch Set 1: (3 comments) I leave some minor comments. Thank you for the docs! http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml File docs/topics/impala_misc_functions.xml: http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@137 PS1, Line 137: <varname>json_str</varname> is invalid. </p> Will also return NULL if nothing is selected, for example: impala-shell> get_json_object('{"a": 1}', '$.b'); NULL http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@143 PS1, Line 143: <li> * : Denotes the wildcard for [] </li> "*" can also be wildcard for ".", for example: impala-shell> select get_json_object('{"a":true, "b":false, "c":true}', '$.*'); [true,false,true] More examples can be found here: https://github.com/apache/impala/blob/4cc3ff9c6763de10236df351a47324d662766de3/be/src/exprs/expr-test.cc#L9787-L9928 http://gerrit.cloudera.org:8080/#/c/13886/1/docs/topics/impala_misc_functions.xml@288 PS1, Line 288: Each call to <codeph>UUID()</codeph> produces a new arbitrary value. Is this relative to the get_json_object function? -- To view, visit http://gerrit.cloudera.org:8080/13886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04 Gerrit-Change-Number: 13886 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 21 Jul 2019 21:58:08 +0000 Gerrit-HasComments: Yes
