Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13886 )
Change subject: IMPALA-8765: [DOCS] Document the GET_JSON_OBJECT function ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml File docs/topics/impala_misc_functions.xml: http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@143 PS2, Line 143: of nit: or http://gerrit.cloudera.org:8080/#/c/13886/2/docs/topics/impala_misc_functions.xml@199 PS2, Line 199: 'NULL','NULL','3'</codeblock> Looks like we only give examples for "." and "*". It'd be better if we can add one more example for "[]" or "[*]". E.g. ---- QUERY SELECT GET_JSON_OBJECT(t.json, '$[1]'), GET_JSON_OBJECT(t.json, '$[*]') FROM (VALUES ( ('["a", "b", "c"]' AS json), ('["a", "b"]'), ('["a"]') )) t ---- RESULTS 'b','["a","b","c"]' 'b','["a","b"]' 'NULL','a' -- To view, visit http://gerrit.cloudera.org:8080/13886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7135528e84f685bfe1c32d81f4cedb6afc133e04 Gerrit-Change-Number: 13886 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 21:25:45 +0000 Gerrit-HasComments: Yes
