Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/13882/12/be/src/util/bloom-filter.cc File be/src/util/bloom-filter.cc: http://gerrit.cloudera.org:8080/#/c/13882/12/be/src/util/bloom-filter.cc@229 PS12, Line 229: void BloomFilter::Or(const BloomFilterPB& in, BloomFilterPB* out) { I suspect you may have kept the 'directory' field in BloomFilterPB because its sort of difficult to see how to implement a function like this if the data is in a sidecar. I think the solution is that we'll just need to treat the bloom filter as two objects: the BloomFilterPB and a string. Then, in coordinator-filter-state in addition to 'bloom_filter_' field we can add something like a 'bloom_filter_directory_' field, which will be either a string or possibly a kudu::Slice or kudu::faststring depending on what's convenient, and we can maintain both of those in FilterState::ApplyUpdate(). This function will then take four params: BloomFilterPB* in, string directory_in, BloomFilterPB* out, string* directory_out -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 12 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 02 Aug 2019 17:27:25 +0000 Gerrit-HasComments: Yes
