Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC ...................................................................... Patch Set 12: A quick high level reminder about using sidecar for the filter: - the RPC framework assumes the lifetime of the binary buffer referenced by the sidecar is valid till the end of an RPC. If we used to copy the entire filter as a string into the Thrift data structure, it's okay for the filter to disappear / freed before the RPC completes. However, with RPC sidecar, we need to keep the filter alive until the RPC is done. - the KRPC also implements the functionality to cancel an asynchronous in-flight RPC. Not that it's necessarily needed in this patch but that functionality allows the RPC to end early so that the binary blob referred to by sidecar can be freed once the completion callback is invoked. -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 12 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 05 Aug 2019 18:18:59 +0000 Gerrit-HasComments: No
