Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups ...................................................................... Patch Set 2: Code-Review+1 (3 comments) Only giving +1 as it does not compile but LGTM and we need this very soon :-) http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG@11 PS2, Line 11: that have atleast one live executor, number of executor groups that are typo -> at least http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json@2456 PS2, Line 2456: "description": "Total number of executor groups that are in a healthy state", I found the difference between "at least one executor" and "healthy" a bit confusing, could we add text somewhere to explain healthy means having at least the configured minimum number of executors. It also may be worth noting somewhere that cluster-membership.executor-groups.total >= cluster-membership.executor-groups.total-healthy http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py@70 PS2, Line 70: assert any(self._get_num_backends() >= GROUP_SIZE + 1 or sleep(1) The change here is because previously we were fetching number of executors, now we are fetching number of backends? So the +1 is because we have 1 coordinator? Might be worth a comment somewhere. Is there a metric for number of coordinators? [but don't delay this change adding this :-) ] -- To view, visit http://gerrit.cloudera.org:8080/13979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9 Gerrit-Change-Number: 13979 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sun, 04 Aug 2019 19:39:14 +0000 Gerrit-HasComments: Yes
