Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/13979 )
Change subject: IMPALA-8806: Add metrics to improve observability of executor groups ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13979/2//COMMIT_MSG@11 PS2, Line 11: that have at least one live executor, number of executor groups that are > typo -> at least Done http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/13979/2/common/thrift/metrics.json@2456 PS2, Line 2456: "description": "Total number of executor groups that are in a healthy state, that is, have at least the configured minimum number of executors to be considered for admission", > I found the difference between "at least one executor" and "healthy" a bit Done. Also added a dcheck for cluster-membership.executor-groups.total >= cluster-membership.executor-groups.total-healthy. http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py File tests/custom_cluster/test_auto_scaling.py: http://gerrit.cloudera.org:8080/#/c/13979/2/tests/custom_cluster/test_auto_scaling.py@70 PS2, Line 70: cluster_size = GROUP_SIZE + 1 # +1 to include coordinator. > The change here is because previously we were fetching number of executors, Yes the +1 is because we are also counting the coordinator. There is currently no metric for the num of coordinators, if you think it will be useful we can add it in a separate patch like you suggested. -- To view, visit http://gerrit.cloudera.org:8080/13979 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7745ea1c7c6778d3fb5e59adbc873697beb0f3b9 Gerrit-Change-Number: 13979 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2019 20:13:19 +0000 Gerrit-HasComments: Yes
