Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch() ...................................................................... IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch() After raising the maximum bit width for bit packing to 64 bits, DictDecoder accepted bit widths between 32 and 64, but internally it uses 32 bit integers and unpacking ran into a DCHECK. Adding a check to DictDecoder to catch if the bit width is higher than 32. Testing: Added a test that asserts that DictDecoder accepts bit widths 0-32 and rejects higher bit widths which could still be unpacked otherwise. Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4 --- M be/src/util/dict-encoding.h M be/src/util/dict-test.cc 2 files changed, 31 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14019/3 -- To view, visit http://gerrit.cloudera.org:8080/14019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4 Gerrit-Change-Number: 14019 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
