Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch() ...................................................................... Patch Set 4: (1 comment) Looks good, just had one nit about the test http://gerrit.cloudera.org:8080/#/c/14019/4/be/src/util/dict-test.cc File be/src/util/dict-test.cc: http://gerrit.cloudera.org:8080/#/c/14019/4/be/src/util/dict-test.cc@287 PS4, Line 287: EXPECT_TRUE(status.ok()); We have an EXPECT_OK macro for this that will print the error if the check fails. -- To view, visit http://gerrit.cloudera.org:8080/14019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4 Gerrit-Change-Number: 14019 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Aug 2019 16:39:56 +0000 Gerrit-HasComments: Yes
