Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13996 )
Change subject: IMPALA-7375: [DOCS] Added DATE functions ...................................................................... Patch Set 2: (8 comments) Sorry for the very sloppy patch! http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@46 PS2, Line 46: is > are Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@78 PS2, Line 78: data > date Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@1072 PS2, Line 1072: MILLISECONDS > MILLISECOND Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@1180 PS2, Line 1180: '2019-08-17 > closing apostrophe is missing. Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@2159 PS2, Line 2159: arguemtn > argument Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@2249 PS2, Line 2249: IGINYTdays > BIGINT days Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@2939 PS2, Line 2939: 20019 > 2019 Done http://gerrit.cloudera.org:8080/#/c/13996/2/docs/topics/impala_datetime_functions.xml@3255 PS2, Line 3255: If <varname>date</varname> is not valid, e.g. <codeph>DATE'2019-03-32'</codeph>, : returns <codeph>NULL</codeph>. > Actually, if the DATE literal is invalid, you get an error (here and elsewh Done -- To view, visit http://gerrit.cloudera.org:8080/13996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1463731f9ee7fb9ec80d6be2458cffe5c42464b6 Gerrit-Change-Number: 13996 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Aug 2019 20:51:03 +0000 Gerrit-HasComments: Yes
