Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13996 )
Change subject: IMPALA-7375: [DOCS] Added DATE functions ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml File docs/topics/impala_datetime_functions.xml: http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml@432 PS3, Line 432: startdate > date Done http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml@846 PS3, Line 846: 2001-01-01 00:00:00 > DATE '2001-01-01' Done http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml@886 PS3, Line 886: 12:01 > 12:01 AM Done http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml@1644 PS3, Line 1644: DATE'2019-01-01' > I think this should be DATE'2019-01-31' Done http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml@1872 PS3, Line 1872: <p> : Any references to the <codeph>NOW()</codeph> function are evaluated at the start of : a query. All calls to <codeph>NOW()</codeph> within the same query return the same : value, and the value does not depend on how long the query takes. : </p> > You could add a similar section to the current_date() doc. Done http://gerrit.cloudera.org:8080/#/c/13996/3/docs/topics/impala_datetime_functions.xml@2858 PS3, Line 2858: <p> : If <varname>date</varname> is not valid, e.g. <codeph>DATE'2019-03-32'</codeph>, : returns an error. : </p> > This section and section in L2899-L2902 could be probably removed. Done -- To view, visit http://gerrit.cloudera.org:8080/13996 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1463731f9ee7fb9ec80d6be2458cffe5c42464b6 Gerrit-Change-Number: 13996 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 17:49:22 +0000 Gerrit-HasComments: Yes
