Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 )
Change subject: IMPALA-8755: Frontend support for Z-ordering ...................................................................... Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java: http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeFileStmt.java@58 PS5, Line 58: getRowFormat(), HdfsFileFormat.fromThrift(getFileFormat()), compression, null, > line too long (102 > 90) Done http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2581 PS5, Line 2581: "tblproperties ('sort.algorithm'='ZORDER')", "Table definition must not " + > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2469 PS5, Line 2469: ParserError("ALTER TABLE TEST PARTITION (year=2009, month=4) SORT BY ZORDER " + > line too long (96 > 90) Done http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2629 PS5, Line 2629: // Create table like other table with zsort columns > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/13955/5/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@262 PS5, Line 262: // Add a test table with a SORT BY ZORDER clause to test that the corresponding sort > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py File tests/custom_cluster/test_zorder.py: http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@18 PS5, Line 18: import shlex > flake8: F401 'pytest' imported but unused Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@22 PS5, Line 22: from tests.common.custom_cluster_test_suite import CustomClusterTestSuite > flake8: F401 'copy.deepcopy' imported but unused Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@33 PS5, Line 33: VALID_SECTION_NAMES = ["CREATE_TABLE", "CREATE_VIEW", "QUERY", "RESULTS"] > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@78 PS5, Line 78: > flake8: E501 line too long (97 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@81 PS5, Line 81: @ > flake8: E303 too many blank lines (2) Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@90 PS5, Line 90: # definition. The table is created, then the output of "SHOW CREATE TABLE" is used to > flake8: E303 too many blank lines (3) Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@94 PS5, Line 94: # Properties to filter before comparing results > flake8: E302 expected 2 blank lines, found 3 Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@254 PS5, Line 254: RESULTS_DB_NAME_TOKEN = "show_create_table_test_db" > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/13955/5/tests/custom_cluster/test_zorder.py@302 PS5, Line 302: > flake8: W391 blank line at end of file Done -- To view, visit http://gerrit.cloudera.org:8080/13955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie122002ca8f52ca2c1e1ec8ff1d476ae1f4f875d Gerrit-Change-Number: 13955 Gerrit-PatchSet: 6 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2019 12:37:16 +0000 Gerrit-HasComments: Yes
