Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 )
Change subject: IMPALA-8755: Frontend support for Z-ordering ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/13955/6/common/thrift/DataSinks.thrift File common/thrift/DataSinks.thrift: http://gerrit.cloudera.org:8080/#/c/13955/6/common/thrift/DataSinks.thrift@83 PS6, Line 83: // Sorting algorithm. If not lexical, the backend should not populate the : // RowGroup::sorting_columns list in parquet files. : 7: required Types.TSortingAlgorithm sorting_algorithm > I think it's rather an 'order' than an 'algorithm'. Algorithm is e.g. quick You are right, replaced 'algorithm' with 'order'. The Parquet stuff is relevant to the sort_columns parameter above, and I would leave it there for clarification. http://gerrit.cloudera.org:8080/#/c/13955/6/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-parser.cup: http://gerrit.cloudera.org:8080/#/c/13955/6/fe/src/main/cup/sql-parser.cup@1399 PS6, Line 1399: RESULT = new CreateTableLikeStmt(tbl_def.getTblName(), > nit: whitespaces at line end Done http://gerrit.cloudera.org:8080/#/c/13955/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/13955/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2570 PS6, Line 2570: > nit: missing words Done http://gerrit.cloudera.org:8080/#/c/13955/6/testdata/workloads/functional-query/queries/QueryTest/create-table-like-table-zorder.test File testdata/workloads/functional-query/queries/QueryTest/create-table-like-table-zorder.test: http://gerrit.cloudera.org:8080/#/c/13955/6/testdata/workloads/functional-query/queries/QueryTest/create-table-like-table-zorder.test@24 PS6, Line 24: string_col > We shouldn't allow string cols to be sorted by ZORDER. It's better to prohi Done -- To view, visit http://gerrit.cloudera.org:8080/13955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie122002ca8f52ca2c1e1ec8ff1d476ae1f4f875d Gerrit-Change-Number: 13955 Gerrit-PatchSet: 6 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Aug 2019 16:52:15 +0000 Gerrit-HasComments: Yes
