Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13922 )
Change subject: IMPALA-8795 : Enable event polling by default in tests ...................................................................... Patch Set 7: (24 comments) http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py File tests/common/environ.py: http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@332 PS7, Line 332: w flake8: E501 line too long (101 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@341 PS7, Line 341: , flake8: E501 line too long (117 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@350 PS7, Line 350: i flake8: F821 undefined name 'impala_url' http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/environ.py@384 PS7, Line 384: r flake8: E501 line too long (102 > 90 characters) http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py@971 PS7, Line 971: l flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/common/impala_test_suite.py@971 PS7, Line 971: """Confirm the database with 'db_name' is present in the impalad's local catalog. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/custom_cluster/test_hive_parquet_codec_interop.py File tests/custom_cluster/test_hive_parquet_codec_interop.py: http://gerrit.cloudera.org:8080/#/c/13922/7/tests/custom_cluster/test_hive_parquet_codec_interop.py@91 PS7, Line 91: E flake8: F821 undefined name 'EventProcessorUtils' http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py File tests/metadata/test_refresh_partition.py: http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py@66 PS7, Line 66: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/metadata/test_refresh_partition.py@66 PS7, Line 66: EventProcessorUtils.wait_for_event_processing(self.hive_client) line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@22 PS7, Line 22: import logging flake8: F401 'logging' imported but unused http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@28 PS7, Line 28: class EventProcessorUtils(object): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@31 PS7, Line 31: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@47 PS7, Line 47: T flake8: F821 undefined name 'TimeoutError' http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@49 PS7, Line 49: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@53 PS7, Line 53: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@53 PS7, Line 53: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@54 PS7, Line 54: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@54 PS7, Line 54: @staticmethod line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@62 PS7, Line 62: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@62 PS7, Line 62: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@66 PS7, Line 66: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@66 PS7, Line 66: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@69 PS7, Line 69: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/13922/7/tests/util/event_processor_utils.py@69 PS7, Line 69: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/13922 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138 Gerrit-Change-Number: 13922 Gerrit-PatchSet: 7 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Aug 2019 22:07:12 +0000 Gerrit-HasComments: Yes