Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13922 )

Change subject: IMPALA-8795 : Enable event polling by default in tests
......................................................................


Patch Set 8:

(25 comments)

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@332
PS8, Line 332: w
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@341
PS8, Line 341: ,
flake8: E501 line too long (117 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@350
PS8, Line 350: i
flake8: F821 undefined name 'impala_url'


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/environ.py@384
PS8, Line 384: r
flake8: E501 line too long (102 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py@971
PS8, Line 971: l
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/common/impala_test_suite.py@971
PS8, Line 971:     """Confirm the database with 'db_name' is present in the 
impalad's local catalog.
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@43
PS8, Line 43: ,
flake8: E231 missing whitespace after ','


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@63
PS8, Line 63: R
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@77
PS8, Line 77: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@79
PS8, Line 79:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@79
PS8, Line 79:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@86
PS8, Line 86: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@88
PS8, Line 88:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@88
PS8, Line 88:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@91
PS8, Line 91: )
flake8: E501 line too long (92 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@103
PS8, Line 103:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@103
PS8, Line 103:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@112
PS8, Line 112:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@112
PS8, Line 112:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@121
PS8, Line 121:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_event_processing.py@121
PS8, Line 121:
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_hive_parquet_codec_interop.py
File tests/custom_cluster/test_hive_parquet_codec_interop.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/custom_cluster/test_hive_parquet_codec_interop.py@91
PS8, Line 91: E
flake8: F821 undefined name 'EventProcessorUtils'


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py
File tests/metadata/test_refresh_partition.py:

http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@66
PS8, Line 66:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@66
PS8, Line 66:       
EventProcessorUtils.wait_for_event_processing(self.hive_client)
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/13922/8/tests/metadata/test_refresh_partition.py@136
PS8, Line 136: "
flake8: E126 continuation line over-indented for hanging indent



--
To view, visit http://gerrit.cloudera.org:8080/13922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7279349d4900e24fbcf558f290549496844ce138
Gerrit-Change-Number: 13922
Gerrit-PatchSet: 8
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Sat, 17 Aug 2019 06:49:19 +0000
Gerrit-HasComments: Yes

Reply via email to