Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 )
Change subject: IMPALA-8691: Query option to disable data cache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14015/1/be/src/runtime/io/request-ranges.h File be/src/runtime/io/request-ranges.h: http://gerrit.cloudera.org:8080/#/c/14015/1/be/src/runtime/io/request-ranges.h@180 PS1, Line 180: BufferOpts(bool try_hdfs_cache, bool try_data_cache) > Can we use enums or a bitmask or something? Two booleans related to caching Using a bitmask doesn't hide the complexity of having two caches. Callers still have to make the call on which if any of the two caches it should use. Eventually, the two caches should converge but that's a bigger change. That said, if you think using a bitmask / enum makes things less confusing, I am happy to change it. USE_HDFS_CACHE | USE_DATA_CACHE -- To view, visit http://gerrit.cloudera.org:8080/14015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39122ac38435cedf94b2b39145863764d0b5b6c8 Gerrit-Change-Number: 14015 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2019 21:46:13 +0000 Gerrit-HasComments: Yes
