Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 )
Change subject: IMPALA-8691: Query option to disable data cache ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14015/1/be/src/runtime/io/request-ranges.h File be/src/runtime/io/request-ranges.h: http://gerrit.cloudera.org:8080/#/c/14015/1/be/src/runtime/io/request-ranges.h@180 PS1, Line 180: BufferOpts(bool try_hdfs_cache, bool try_data_cache) > Yeah, it would minimise the chance of transposing or passing in the wrong a Done http://gerrit.cloudera.org:8080/#/c/14015/1/tests/custom_cluster/test_data_cache.py File tests/custom_cluster/test_data_cache.py: http://gerrit.cloudera.org:8080/#/c/14015/1/tests/custom_cluster/test_data_cache.py@79 PS1, Line 79: def test_data_cache_disablement(self, vector): > Can we move one or both of the other tests to exhaustive to make up for the Done -- To view, visit http://gerrit.cloudera.org:8080/14015 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39122ac38435cedf94b2b39145863764d0b5b6c8 Gerrit-Change-Number: 14015 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2019 16:24:08 +0000 Gerrit-HasComments: Yes
