Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14077 )
Change subject: IMPALA-8868: Fix 401 response when LDAP and Kerberos are enabled ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14077/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/14077/1/be/src/transport/THttpServer.cpp@175 PS1, Line 175: if (!got_basic_auth) basic_auth_token = ""; The API of TryStripPrefixString() is weird. I find the flow a little confusing with how it's mutating basic_auth_token then undoing it. Maybe it would be more obvious if you used a temporary for the output argument of TryStripPrefixString(). I.e. something like string stripped_basic_auth_token; bool got_basic_auth = TryStripPrefixString(auth_value_, "Basic ", &basic_auth_token) string basic_auth_token = got_basic_auth ? move(stripped_basic_auth_token) : ""; Same for negotiate_auth_token below. -- To view, visit http://gerrit.cloudera.org:8080/14077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138f33783bfd0f8f9b8db242589a9cc75cfd392a Gerrit-Change-Number: 14077 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2019 23:35:31 +0000 Gerrit-HasComments: Yes
