Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14077 )
Change subject: IMPALA-8868: Fix 401 response when LDAP and Kerberos are enabled ...................................................................... Patch Set 2: Code-Review+2 (1 comment) carrying forward http://gerrit.cloudera.org:8080/#/c/14077/1/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/14077/1/be/src/transport/THttpServer.cpp@175 PS1, Line 175: TryStripPrefixString(auth_value_, "Basic ", &stripped_basic_auth_token); > The API of TryStripPrefixString() is weird. I find the flow a little confus Done -- To view, visit http://gerrit.cloudera.org:8080/14077 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I138f33783bfd0f8f9b8db242589a9cc75cfd392a Gerrit-Change-Number: 14077 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 17 Aug 2019 00:04:39 +0000 Gerrit-HasComments: Yes
