Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14129 )
Change subject: IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc@138 PS3, Line 138: bool* eos > Is it assumed that the caller will initialize this to false or should we ex We should initialise it. I feel pretty strongly that callees should not assume output parameters are initialised, unless it's explicitly documented in the method comment. It's pretty easy to introduce subtle bugs this way. http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc@197 PS3, Line 197: current_batch_.reset(); It seems a bit unnecessary to create and destroy the batch repeatedly. It's going to cause a bunch of unnecessary malloc()/free() calls. That might not be a problem, but we could just create it in Open() and reuse it until Close(). -- To view, visit http://gerrit.cloudera.org:8080/14129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd4b397ab6457a4f85e635f239b2c67130fcce4 Gerrit-Change-Number: 14129 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2019 20:24:35 +0000 Gerrit-HasComments: Yes
