Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14129 )
Change subject: IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.h File be/src/exec/buffered-plan-root-sink.h: http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.h@147 PS3, Line 147: current_batch_ == nullptr > !current_batch_; Replaced with 'current_batch_empty_'. http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc File be/src/exec/buffered-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc@114 PS3, Line 114: current_batch_ != nullptr) > !current_batch_ Replaced this with a new instance variable 'current_batch_empty_' which tracks the state of 'current_batch_' (new variable is necessary to support re-using current_batch_ across reads from the SpillableRowBatchQueue. http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc@138 PS3, Line 138: bool* eos > We should initialise it. Done http://gerrit.cloudera.org:8080/#/c/14129/3/be/src/exec/buffered-plan-root-sink.cc@197 PS3, Line 197: current_batch_.reset(); > It seems a bit unnecessary to create and destroy the batch repeatedly. It's Changed it so 'current_batch_' is initialized in Open() and destroyed in Close(). Added 'current_batch_empty_' to track the state of 'current_batch_' rather than relying on nullptr checks. -- To view, visit http://gerrit.cloudera.org:8080/14129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8dd4b397ab6457a4f85e635f239b2c67130fcce4 Gerrit-Change-Number: 14129 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2019 21:47:19 +0000 Gerrit-HasComments: Yes
