Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG@13 PS1, Line 13: 'impala-server.ready' metric. One thing I didn't think about was authentication - is it gonna be messy enabling authentication if everything that's running health checks (kubernetes, etc) has to be able to authenticate with the web server? If we think that's going to be a problem, maybe we should be starting a second unauthenticated webserver with just this endpoint. http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/14146/1/be/src/service/impala-http-handler.cc@179 PS1, Line 179: (*data) << "OK"; It feels wrong to me that we're not setting *response - I guess the caller is initialising it but it seems brittle. -- To view, visit http://gerrit.cloudera.org:8080/14146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615 Gerrit-Change-Number: 14146 Gerrit-PatchSet: 1 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 03:38:23 +0000 Gerrit-HasComments: Yes
