Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14146 )
Change subject: IMPALA-8895: Expose daemon health endpoint ...................................................................... Patch Set 2: Code-Review+2 (1 comment) I'm OK with proceeding as-is and dealing with the authentication in a follow-on change. http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14146/1//COMMIT_MSG@13 PS1, Line 13: 'impala-server.ready' metric. > Thats a good point. Do you think we should add a webserver in this patch or I think the second alternative sounds better if we can do it cleanly (it looks like the webserver accesses a lot of global flags). -- To view, visit http://gerrit.cloudera.org:8080/14146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05889e21bbb1b97b23fad9928b9e61e5dbff2615 Gerrit-Change-Number: 14146 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Aug 2019 17:23:08 +0000 Gerrit-HasComments: Yes
