Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 )
Change subject: IMPALA-8579: Ignore trivial alter table/partition events. ...................................................................... Patch Set 2: (4 comments) Looks good to me. Few more suggestions below and its good to go from my side. Thanks! http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@481 PS2, Line 481: getParametersToIgnore I think what I meant was something like static final List<String> parametersToIgnore = new ImmutableList.Builder<>() .add("transient_lastDdlTime") .add("totalSize") .add("numFilesErasureCoded") .add("numFiles") .build(); You can define this constant in the base class of all the events which invalidate/refresh i.e TableInvalidatingEvent and it can be directly accessed. The current approch in the patch will create this list every single time. http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@482 PS2, Line 482: transient_lastDdlTime I did a grep for this property and I see that it is being used in some places of the code where catalog sets it or removes it from the properties. But I don't see it being used anywhere so I think its okay to ignore changes to this property in the events. http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1032 PS2, Line 1032: canBeSkipped Can we refactor this method to static boolean canBeSkipped(paramBefore, paramAfter) in TableInvalidatingEvent class? That way you can reuse it for both alterTable and alterPartition event. http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1049 PS2, Line 1049: setTrivialParameters Do you need a separate method for this? -- To view, visit http://gerrit.cloudera.org:8080/14145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01a59d5170accc014f76f14eb526d96ddcf61f76 Gerrit-Change-Number: 14145 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 19:05:18 +0000 Gerrit-HasComments: Yes
