Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14145 )
Change subject: IMPALA-8579: Ignore trivial alter table/partition events. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14145/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1032 PS2, Line 1032: canBeSkipped > canBeSkipped() needs to compare entire objects and not just the parameters, makes sense. In that case make canBeSkipped a abstract method in TableInvalidatingEvent and implement it for AlterTable and AlterPartition event. The code to compare the parameters can be refactored and reused. -- To view, visit http://gerrit.cloudera.org:8080/14145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01a59d5170accc014f76f14eb526d96ddcf61f76 Gerrit-Change-Number: 14145 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2019 22:37:18 +0000 Gerrit-HasComments: Yes
