Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14119 )
Change subject: IMPALA-8879: upgrade bootstrap for debug page to 4.3.1 ...................................................................... Patch Set 4: (4 comments) I compare the web pages with the current version and still find somethings worth to fix. May need to go through https://getbootstrap.com/docs/4.1/migration/ for things we use. http://gerrit.cloudera.org:8080/#/c/14119/4/www/catalog.tmpl File www/catalog.tmpl: http://gerrit.cloudera.org:8080/#/c/14119/4/www/catalog.tmpl@166 PS4, Line 166: panel Now the /catalog page looks like missing styles. I found that all "panel" stuffs should be changed to "card" according to https://getbootstrap.com/docs/4.1/migration/#panels http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl File www/common-header.tmpl: http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@42 PS4, Line 42: nit: Looks like we use white spaces instead of tabs in other places. http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@54 PS4, Line 54: <header class="navbar navbar-default navbar-expand bg-light navbar-static-top" id="top" role="banner"> We used to have a 20px margin-bottom in the navbar. It'd be better to find a way to implement it in Bootstrap 4. Maybe explicitly set it in style? http://gerrit.cloudera.org:8080/#/c/14119/4/www/common-header.tmpl@68 PS4, Line 68: style='width:80%' Add 'max-width:3000px' or give it a larger value in the style. The boxes look narrow in my browser. It looks like we need to set this explicitly in Bootstrap 4: https://getbootstrap.com/docs/4.1/migration/#grid-system -- To view, visit http://gerrit.cloudera.org:8080/14119 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib58f407574f590825d208424a8c0fd101b0a19a7 Gerrit-Change-Number: 14119 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 30 Aug 2019 03:32:43 +0000 Gerrit-HasComments: Yes
