Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14173 )
Change subject: IMPALA-8897 (part 2): Fix javascript to work with Knox integration ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14173/1/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14173/1/tests/webserver/test_web_pages.py@673 PS1, Line 673: results = grep_dir("/home/thomas/Impala/www", regex, ".*\.tmpl") I missed this when reviewing the first patch, but it looks like the path is wrong here. http://gerrit.cloudera.org:8080/#/c/14173/1/www/common-header.tmpl File www/common-header.tmpl: http://gerrit.cloudera.org:8080/#/c/14173/1/www/common-header.tmpl@76 PS1, Line 76: compatability nit: compatibility http://gerrit.cloudera.org:8080/#/c/14173/1/www/common-header.tmpl@76 PS1, Line 76: shuold should -- To view, visit http://gerrit.cloudera.org:8080/14173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3de9fd1bbb8bb38ce63b3160fcafd33eb0530581 Gerrit-Change-Number: 14173 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2019 17:11:00 +0000 Gerrit-HasComments: Yes
