Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14173
to look at the new patch set (#2).
Change subject: IMPALA-8897 (part 2): Fix javascript to work with Knox
integration
......................................................................
IMPALA-8897 (part 2): Fix javascript to work with Knox integration
This patch qualifies all urls accessed via javascript in the webui
with the appropriate host:port in order to allow these urls to work
when the connection to the webui is being proxied through Apache Knox.
It accomplishes this with the function make_url(), which takes the
href of a link from the page, which may have been rewritten by Knox,
and appends a path to it.
This patch also fixes on issue on the /admissions page, where
resetting a pool's stats could fail due to the page being reloaded
before the reset is executed. Fixed by moving the call to reload to
the completion callback for the 'reset' endpoint.
Testing:
- Added a regex to test_knox_compatability that performs a rough check
for places in the tmpl files where urls are used in javascript
without calling make_url().
Change-Id: I3de9fd1bbb8bb38ce63b3160fcafd33eb0530581
---
M tests/webserver/test_web_pages.py
M www/admission_controller.tmpl
M www/common-header.tmpl
M www/query_plan.tmpl
M www/query_summary.tmpl
M www/rpcz.tmpl
6 files changed, 38 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/14173/2
--
To view, visit http://gerrit.cloudera.org:8080/14173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3de9fd1bbb8bb38ce63b3160fcafd33eb0530581
Gerrit-Change-Number: 14173
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
