Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 )
Change subject: IMPALA-8755: Frontend support for Z-ordering ...................................................................... Patch Set 12: Code-Review+1 (1 comment) Good work Norbert. In general the patch looks good to me. Please change the java docs for the methods that changed signatures or return types due to your patch. Apart from that, I see this has been reviewed already. I'm going to give my +1. http://gerrit.cloudera.org:8080/#/c/13955/12/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/13955/12/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@206 PS12, Line 206: Returns a list of positions of the sort columns within the table's list of columns Nit: Maybe change this statement to "Returns a Pair of list of positions of the sort columns within the table's list of columns and corresponding sort order" or something similar? -- To view, visit http://gerrit.cloudera.org:8080/13955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie122002ca8f52ca2c1e1ec8ff1d476ae1f4f875d Gerrit-Change-Number: 13955 Gerrit-PatchSet: 12 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 Sep 2019 18:58:53 +0000 Gerrit-HasComments: Yes
