Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13955 )
Change subject: IMPALA-8755: Frontend support for Z-ordering ...................................................................... Patch Set 14: (1 comment) Found a nit and PlannerTest.testInsertSortByZorder fails. Otherwise LGTM. http://gerrit.cloudera.org:8080/#/c/13955/14/fe/src/main/java/org/apache/impala/planner/TableSink.java File fe/src/main/java/org/apache/impala/planner/TableSink.java: http://gerrit.cloudera.org:8080/#/c/13955/14/fe/src/main/java/org/apache/impala/planner/TableSink.java@96 PS14, Line 96: sortColumns nit: comment outdated -- To view, visit http://gerrit.cloudera.org:8080/13955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie122002ca8f52ca2c1e1ec8ff1d476ae1f4f875d Gerrit-Change-Number: 13955 Gerrit-PatchSet: 14 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2019 14:11:25 +0000 Gerrit-HasComments: Yes
