Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 )
Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@130 PS3, Line 130: JARO_DISTANCE Shouldn't the short versions of these functions be displayed here? (JARO_DST, JARO_SIM, JW_DST, JW_SIM) http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@833 PS3, Line 833: ps://en.wikiped Not sure, if it's something to point out, but boost_threshold for some reasons is not mentioned in the current revision of the Wikipedia article. We followed an older version (linked below), since other reference implementations contained it, and was also requested by customers. The difference in short is, that the current Wikipedia revision always applies the prefix weight, while our implementation only does over 0.7 Jaro-distance value. https://ipfs.io/ipfs/QmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco/wiki/Jaro%E2%80%93Winkler_distance.html -- To view, visit http://gerrit.cloudera.org:8080/14249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3 Gerrit-Change-Number: 14249 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Sep 2019 07:42:09 +0000 Gerrit-HasComments: Yes
