Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14249 )
Change subject: IMPALA-8861: [DOCS] Documented Jaro and Jaro-Winkler functions ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@130 PS3, Line 130: JARO_DISTANCE > Shouldn't the short versions of these functions be displayed here? (JARO_DS Done http://gerrit.cloudera.org:8080/#/c/14249/3/docs/topics/impala_string_functions.xml@833 PS3, Line 833: boost_threshold > Not sure, if it's something to point out, but boost_threshold for some reas I updated the link to point to the older Wikipedia article you mentioned. Otherwise, I don't feel that it is necessary to mention the difference b/w 2 versions of Wikipedia articles. -- To view, visit http://gerrit.cloudera.org:8080/14249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89410128acfc31d5072cf04a28bef26221f39f3 Gerrit-Change-Number: 14249 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Greg Rahn <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 19 Sep 2019 16:51:01 +0000 Gerrit-HasComments: Yes
