Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14275 )
Change subject: IMPALA-8926, IMPALA-8957: Fix result spooling flaky tests ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14275/2/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/14275/2/tests/query_test/test_fetch.py@50 PS2, Line 50: # Sleep for 2.5 seconds so that the ClientFetchWaitTimer is >= 1s. : sleep(2.5) Do I understand correctly that we want to ensure that the timers are >= 1s just to make the regexps simpler? It would be nice to have function like getProfileTimerSec(profile, timer_name) that parses the profile's duration format and returns it as double, e.g. 1.106 for 1s106ms. This could make the code easier to understand + allow us to use smaller sleep times. There is a already a function that does the parsing for a single line and returns the value in millisecs: tests.util.parse_util import parse_duration_string_ms I am ok with merging the patch in it's current state to unflake tests - in that case I can create a follow up Jira for this convenience function. -- To view, visit http://gerrit.cloudera.org:8080/14275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3042f592bc79785e43ebc7b09ac1270eae8ed66f Gerrit-Change-Number: 14275 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Sep 2019 17:31:57 +0000 Gerrit-HasComments: Yes
