Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14275 )
Change subject: IMPALA-8926, IMPALA-8957: Fix result spooling flaky tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14275/2/be/src/exec/blocking-plan-root-sink.cc File be/src/exec/blocking-plan-root-sink.cc: http://gerrit.cloudera.org:8080/#/c/14275/2/be/src/exec/blocking-plan-root-sink.cc@67 PS2, Line 67: AddBatch > AddRows? Done http://gerrit.cloudera.org:8080/#/c/14275/2/tests/query_test/test_fetch.py File tests/query_test/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/14275/2/tests/query_test/test_fetch.py@50 PS2, Line 50: # Sleep for 2.5 seconds so that the ClientFetchWaitTimer is >= 1s. : sleep(2.5) > Do I understand correctly that we want to ensure that the timers are >= 1s I explicitly want to check that these counters are greater than 1s to ensure that they are getting updated properly. I changed the code to use 'parse_duration_string_ms' which does seem cleaner. -- To view, visit http://gerrit.cloudera.org:8080/14275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3042f592bc79785e43ebc7b09ac1270eae8ed66f Gerrit-Change-Number: 14275 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2019 19:40:35 +0000 Gerrit-HasComments: Yes
