Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14272 )
Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@69 PS4, Line 69: time.sleep(total_timeout) Sleeps in tests are really not a good practice unless you're actually directly testing something timing-related, things end up being slow and brittle. Why is this less flaky than the above function? Can we deflake the above function? Is the flakiness coming from the logic around the notification ids, or waiting for the catalog update to propagate? It seems like we could directly check for the catalog update by checking when the catalog version gets propagated. I guess the catalog doesn't actually expose its latest version, but that seems like an oversight. -- To view, visit http://gerrit.cloudera.org:8080/14272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972 Gerrit-Change-Number: 14272 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2019 19:08:01 +0000 Gerrit-HasComments: Yes
