Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14272 )
Change subject: IMPALA-8795 : Enable event polling by default in dockerized tests. ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py File tests/util/event_processor_utils.py: http://gerrit.cloudera.org:8080/#/c/14272/4/tests/util/event_processor_utils.py@69 PS4, Line 69: time.sleep(total_timeout) > Sleeps in tests are really not a good practice unless you're actually direc The flakiness is coming from the logic in the above function. During parallel runs events are generated by deferent tests and thus changing the event_id counter resulting in the above function to return for incorrect reasons. This function, however waits for sufficient amount observed to have the update propagated. I agree that this is brittle. I will try to change this to wait till actual catalog update propagation, if it is possible. -- To view, visit http://gerrit.cloudera.org:8080/14272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I222b64236060b3c4c2d554e2f10e129984ebe972 Gerrit-Change-Number: 14272 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2019 20:52:10 +0000 Gerrit-HasComments: Yes
