Yongzhi Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14234 )

Change subject: IMPALA-7637: Add more hash table stats to profile
......................................................................


Patch Set 6:

(4 comments)

Rebase and fix the tests.

http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:

http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@676
PS3, Line 676:
> So does 'Probes:.*\((\d+)\)', positive look-behinds are useful when you nee
Done


http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@677
PS3, Line 677: u
> Done
Done


http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@688
PS3, Line 688: ry needs load
> Done
Done


http://gerrit.cloudera.org:8080/#/c/14234/3/tests/query_test/test_observability.py@691
PS3, Line 691: l
> Done
Done



--
To view, visit http://gerrit.cloudera.org:8080/14234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87
Gerrit-Change-Number: 14234
Gerrit-PatchSet: 6
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 17:28:51 +0000
Gerrit-HasComments: Yes

Reply via email to