Yongzhi Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14234 )

Change subject: IMPALA-7637: Add more hash table stats to profile
......................................................................


Patch Set 5:

(2 comments)

patch 5 fixed style issues.

http://gerrit.cloudera.org:8080/#/c/14234/4/be/src/exec/hash-table.h
File be/src/exec/hash-table.h:

http://gerrit.cloudera.org:8080/#/c/14234/4/be/src/exec/hash-table.h@650
PS4, Line 650: arent_profile
> nit: parent_profile
Done


http://gerrit.cloudera.org:8080/#/c/14234/4/be/src/exec/hash-table.h@650
PS4, Line 650:       RuntimeProfile* parent_profile);
> nit: the formatting convention puts the open parenthesis on the previous li
Done



--
To view, visit http://gerrit.cloudera.org:8080/14234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fd875dd1af8031242fd5f5ff554d3a71aaa6f87
Gerrit-Change-Number: 14234
Gerrit-PatchSet: 5
Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Mon, 23 Sep 2019 20:40:37 +0000
Gerrit-HasComments: Yes

Reply via email to