Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 )
Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. ...................................................................... Patch Set 2: (4 comments) Bunch of nits. http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2220 PS2, Line 2220: CatalogException Any reason this is CatalogException instead of DatabaseNotFound...? While we are here, how about handling the DatabaseNotFoundException here in this method and not throw anything? (since we call the method updateDbIfExists anyway) http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1228 PS2, Line 1228: OKay nit: Okay http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1235 PS2, Line 1235: } catch (DatabaseNotFoundException e) { Consider moving the exception handling to updateDbIfExists? http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@2336 PS2, Line 2336: dropScalarFunctionFromImapala Typo, impala -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2019 21:44:29 +0000 Gerrit-HasComments: Yes
