Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14296 )
Change subject: IMPALA-8968: Alter database events on dropped database should not put events processor in error state. ...................................................................... Patch Set 2: (2 comments) Just have some comments in the tests http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@557 PS2, Line 557: scalar function Do you think we need to add coverage for native functions here? There's a if-branch inside CatalogOpExecutor.createFunction() checking isPersistentJavaFn. Maybe we need to cover the else-clause of it. http://gerrit.cloudera.org:8080/#/c/14296/2/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@580 PS2, Line 580: assertEquals(EventProcessorStatus.ACTIVE, eventsProcessor_.getStatus()); Need to call eventsProcessor_.processEvents() before this? -- To view, visit http://gerrit.cloudera.org:8080/14296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f76136aeff35d1d38fc8b3d9a38da399d36eced Gerrit-Change-Number: 14296 Gerrit-PatchSet: 2 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2019 22:12:19 +0000 Gerrit-HasComments: Yes
