Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13751 )
Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py File tests/stress/test_acid_stress.py: http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49 PS3, Line 49: V > nit: no space needed Done http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@67 PS3, Line 67: writ > write? Done http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@68 PS3, Line 68: rom Hive." > Should we add another role and test for an Impala writer? We should, but I consider that a different test. For Impala writers to most interesting is the case when there are multiple impalad's doing inserts in parallel. http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@86 PS3, Line 86: result = self.client.execute("select * from %s" % tbl_name) : if len(res > nit: __verify_result() could just return when result.data is empty I made this a bit stricter - we shouldn't see 0 rows after the first insert, as insert overwrite statement always reset to 1 row. http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@94 PS3, Line 94: ytes > nit: extra indentation Done -- To view, visit http://gerrit.cloudera.org:8080/13751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8 Gerrit-Change-Number: 13751 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2019 11:57:55 +0000 Gerrit-HasComments: Yes
