Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13751 )

Change subject: IMPALA-8648: Add a simple stress test for reading ACID tables
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py
File tests/stress/test_acid_stress.py:

http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@49
PS3, Line 49: '
> nit: extra '
Done


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@114
PS3, Line 114: CTRL+C can't interrupt the test
> You can use pool.map_async(...).get(long timeout) which will handle keyboar
Thanks, it works well!


http://gerrit.cloudera.org:8080/#/c/13751/3/tests/stress/test_acid_stress.py@116
PS3, Line 116:     for i in pool.imap(do_role, ["impala", "hive"]):
             :       pass
> why not just simply pool.imap()? Or better, pool.map_async(...).get(...)?
Done



--
To view, visit http://gerrit.cloudera.org:8080/13751
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I57d7ab5bf39e9225e50add0a234849ed20d8b3f8
Gerrit-Change-Number: 13751
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 01 Oct 2019 11:58:58 +0000
Gerrit-HasComments: Yes

Reply via email to