Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14339 )

Change subject: IMPALA-8899: Add cookie support to the webui
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc
File be/src/util/webserver.cc:

http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@223
PS1, Line 223:     response_headers.push_back(Substitute("WWW-Authenticate: 
Negotiate $0", resp_token_b64));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@230
PS1, Line 230: Webserver::Webserver(MetricGroup* metrics) : 
Webserver(FLAGS_webserver_interface, FLAGS_webserver_port, metrics) {}
line too long (115 > 90)


http://gerrit.cloudera.org:8080/#/c/14339/1/be/src/util/webserver.cc@524
PS1, Line 524:       sq_callback_result_t spnego_result = 
HandleSpnego(connection, request_info, response_headers);
line too long (100 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/14339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 01 Oct 2019 22:21:48 +0000
Gerrit-HasComments: Yes

Reply via email to