Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14339
to look at the new patch set (#3).
Change subject: IMPALA-8899: Add cookie support to the webui
......................................................................
IMPALA-8899: Add cookie support to the webui
This patches takes the machinery for generating and checking cookies
for authentication that was added in IMPALA-8584 and applies to the
webui.
It also fixes an issue where some clients may return the cookie value
surrounded by "".
It adds metrics for both SPNEGO auth success/failure and cookie auth
success/failure to the webserver.
This patch also fixes IMPALA-8898 by returning an empty cookie with a
Max-Age of 0 on requests where an invalid cookie was provided to
indicate to the client that the cookie should be deleted.
Testing:
- Added a test that uses curl to access the webserver with SPNEGO
enabled while storing and using cookies. This test only runs when
curl is present, which is generally not the case in our automated
testing runs.
Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4
---
M be/src/catalog/catalogd-main.cc
M be/src/rpc/authentication.cc
M be/src/rpc/cookie-util.cc
M be/src/rpc/cookie-util.h
M be/src/runtime/exec-env.cc
M be/src/statestore/statestored-main.cc
M be/src/util/webserver-test.cc
M be/src/util/webserver.cc
M be/src/util/webserver.h
M common/thrift/metrics.json
M fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java
11 files changed, 276 insertions(+), 144 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/14339/3
--
To view, visit http://gerrit.cloudera.org:8080/14339
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30788e0539627ee6154ad8183b124947c5da8ef4
Gerrit-Change-Number: 14339
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
